[SG-666][SG-667] Email is not prefilled and username isn't generated automatically#2109
Merged
LRNcardozoWDF merged 4 commits intomasterfrom Oct 3, 2022
Merged
Conversation
…ame type * Username is auto generated upon navigation
fedemkr
requested changes
Oct 3, 2022
| return; | ||
| } | ||
|
|
||
| var website = (bool)(Cipher?.Login?.HasUris) ? Cipher?.Login?.Uris[0].Host : null; |
Member
There was a problem hiding this comment.
If Cipher or Login is null then when you cast it to bool it will throw an exception, so it should be something like:
var website = (Cipher?.Login?.HasUris ?? false) ? Cipher.Login.Uris[0].Host : null;or another even better way:
var website = Cipher?.Login?.Uris?.FirstOrDefault()?.Host;
Member
Author
There was a problem hiding this comment.
Fixed with second suggestion, thank you for your help.
* Added missing property initialization
fedemkr
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
With this changes email is now prefilled when selecting Plus Adressed Email username type, the username is generated automatically upon navigation and if the chosen item has an URI we pass it correctly as a field for Plus Adressed Email or Catch-all Email username types.
Code changes
Before you submit
dotnet format --verify-no-changes) (required)