Vault: Don't specify page options for ActivityLoading#215
Merged
kspearrin merged 1 commit intobitwarden:masterfrom Dec 18, 2017
Merged
Vault: Don't specify page options for ActivityLoading#215kspearrin merged 1 commit intobitwarden:masterfrom
kspearrin merged 1 commit intobitwarden:masterfrom
Conversation
When specifying page options the loader doesn't appear properly on UWP applications. I also couldn't see the options documented here: https://developer.xamarin.com/api/type/Xamarin.Forms.ActivityIndicator/ Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/loading
branch
from
d254ade to
09af9d0
Compare
Member
|
We still need these options for the other platforms, where they do actually work. |
Author
|
Shouldn't it default to being in the center? Looking at the pictures on that page it looks like these options don't change the position. If they are actually changing the position on the other platforms I can wrap the changes in a conditional. Would you mind checking though? |
Member
|
I'm not sure if that is the default or not. I would have to run on those platforms and check. The screenshots on the dev pages show that, but I'm not sure what settings were actually used in those. |
Member
|
Seems to work the same on Android. |
Member
|
Nevermind. Seems it broke after merging this. I fixed in bitwarden/mobile@6fe5e89 |
Author
|
Thanks for fixing that. Looks good to me. |
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
UCan927
pushed a commit
to UCan927/BitWarden-Android
that referenced
this pull request
Jun 22, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying page options the loader doesn't appear properly on UWP
applications. I also couldn't see the options documented here:
https://developer.xamarin.com/api/type/Xamarin.Forms.ActivityIndicator/
Signed-off-by: Alistair Francis alistair@alistair23.me