Skip to content

[SG-769] Fix crash by ensuring that token for decoding is refreshed before use#2150

Merged
trmartin4 merged 1 commit intomasterfrom
bug/SG-769-Fix-crash-when-clicking-generate-password
Oct 31, 2022
Merged

[SG-769] Fix crash by ensuring that token for decoding is refreshed before use#2150
trmartin4 merged 1 commit intomasterfrom
bug/SG-769-Fix-crash-when-clicking-generate-password

Conversation

@LRNcardozoWDF
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added a call to refresh the token used for decoding before getting the user's email in order to fix a crash.

Code changes

  • ITokenService.cs
  • TokenService.cs : Added new method to refresh token without returning it.
  • GeneratorPageViewModel.cs : Made sure token is refreshed before using it to get user's email.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@LRNcardozoWDF LRNcardozoWDF requested a review from a team October 25, 2022 11:21
@LRNcardozoWDF LRNcardozoWDF changed the title [SG-769] Ensured token for decoding is refreshed before use [SG-769] Fix crash by ensuring that token for decoding is refreshed before use Oct 25, 2022
@trmartin4 trmartin4 merged commit 5a4c81b into master Oct 31, 2022
@trmartin4 trmartin4 deleted the bug/SG-769-Fix-crash-when-clicking-generate-password branch October 31, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on click generate a password Android - Bitwarden crashes when attempting to generate a new password via the autofill flow.

3 participants