Skip to content

Fix for avatar sequence issue on iOS account switching modal#2154

Merged
mpbw2 merged 1 commit intomasterfrom
bugfix-avatarhash
Oct 27, 2022
Merged

Fix for avatar sequence issue on iOS account switching modal#2154
mpbw2 merged 1 commit intomasterfrom
bugfix-avatarhash

Conversation

@mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Oct 27, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The order of avatars (not accounts) would invert each time the account switching list was opened on iOS. Missed it the first time through due to the subtle earth-tones all my test accounts ended up with.

Code changes

  • AvatarImageSource.cs: Added missing _id check to Equals fixed the object comparison (thanks @fedemkr )

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@mpbw2 mpbw2 requested a review from a team October 27, 2022 16:06
@mpbw2 mpbw2 merged commit 77d8afc into master Oct 27, 2022
@mpbw2 mpbw2 deleted the bugfix-avatarhash branch October 27, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants