[SG-166] Two Step Login - Feature Branch#2157
Merged
andrebispo5 merged 5 commits intomasterfrom Oct 28, 2022
Merged
Conversation
* [SG-166] Add UI elements to Home and Login pages. Change VMs to function with new UI. Add new string resources. * [SG-166] Pass email parameter from Home to Login page. * [SG-166] Pass email to password hint page. * [SG-166] Remove remembered email from account switching. * [SG-166] Add GetKnownDevice endpoint to ApiService * [SG-166] Fix GetKnownDevice string uri * [SG-166] Add Renderer for IconLabel control. Add RemoveFontPadding bool property. * [SG-166] include IconLabelRenderer in Android csproj file * [SG-166] Add new control. Add styles for the control. * [SG-166] Add verification to start login if email is remembered * [SG-166] Pass default email to hint page * [SG-166] Login with device button only shows if it is a known device. * [SG-166] Change Remember Email to Remember me. Change Check to Switch control. * [SG-166] Add command to button for SSO Login * Revert "[SG-166] Update fonts to have necessary icons" This reverts commit 472b541. * [SG-166] Remove IconLabel Android renderer. Add RemoveFontPadding effect. * [SG-166] Update font with new device and suitcase icon * [SG-166] Fix RemoveFontPadding effect * [SG-166] Remove unused property in IconLabel * [SG-166] Fix formatting on IconLabelButton.xaml * [SG-166] Update padding effect to IconLabel * [SG-166] Add control variable to run code once on create * [SG-166] Add email validation before continue * [SG-166] Refactor icons * [SG-166] Update iOS Extension font * [SG-166] Remove HomePage login btn step * [SG-166] Make clickable area smaller * [SG-166] Fix hint filled by default * [SG-166] Fix IconButton font issue * [SG-166] Fix iOS extension * [SG-166] Move style to Base instead of platforms * [SG-166] Fix layout for IconLabelButton * [SG-166] Switched EventHandler for Command * [SG-166] Removed event handler * [SG-166] Fix LoginPage layout options * [SG-166] Fix extensions Login null email * [SG-166] Move remembered email logic to viewmodel * [SG-166] Protect method and show dialog in case of error * [SG-166] Rename of GetKnownDevice api method * [SG-166] rename text resource key name * [SG-166] Add close button to iOS extension * [SG-166] Switch event handlers for commands * [SG-166] Change commands UI thread invocation. * [SG-166] Remove Login with device button from the UI
fedemkr
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Feature branch of two step login feature.
#2153
Before you submit
dotnet format --verify-no-changes) (required)