[SG-773][SG-777] Duplicate passwordless login requests#2160
Merged
andrebispo5 merged 7 commits intomasterfrom Oct 31, 2022
Merged
[SG-773][SG-777] Duplicate passwordless login requests#2160andrebispo5 merged 7 commits intomasterfrom
andrebispo5 merged 7 commits intomasterfrom
Conversation
fedemkr
approved these changes
Oct 31, 2022
andrebispo5
changed the title
trmartin4
pushed a commit
that referenced
this pull request
Oct 31, 2022
* [SG-773] Change method call to message send * [SG-773] Introduce lock to avoid concurrent executions of login requests * [SG-773][SG-775] add comment * [SSG-773][SG-775] Refactor passwordlessLoginRequest string to constant (cherry picked from commit 9baa79e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix bug where in certain conditions multiple login request modals could appear to the user.
Code changes
Due to the nature of broadcast receiver, async messages can arrive at the same time causing racing problems. A lock was added to prevent multiple executions of passwordless login requests. The lock object was made static because of android notification clicks firing a new app instance.
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)