[SG-800] Selecting notification for inactive account on iOS while app is open does not display the request#2166
Merged
andrebispo5 merged 2 commits intomasterfrom Nov 4, 2022
Merged
Conversation
If the user never answers the pop up, the lock is never released.
fedemkr
requested changes
Nov 4, 2022
fedemkr
approved these changes
Nov 4, 2022
andrebispo5
added a commit
that referenced
this pull request
Nov 4, 2022
… is open does not display the request (#2166)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix bug where If the user never answers the switch accounts pop up, the lock is never released. This was problematic because when tapping a notification while pop-up was showing, the user navigates to the other account automatically and the pop-up is never dismissed.
Code changes
Removed await to allow the execution flow and lock to be released.
Before you submit
dotnet format --verify-no-changes) (required)