Skip to content

[SG-174] Login with Device Request - Mobile#2167

Merged
andrebispo5 merged 28 commits intomasterfrom
feature/SG-174-login-with-device
Nov 9, 2022
Merged

[SG-174] Login with Device Request - Mobile#2167
andrebispo5 merged 28 commits intomasterfrom
feature/SG-174-login-with-device

Conversation

@andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Nov 4, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add a new login option to the methods list. The login with another device will allow users to log into their accounts using a passwordless method.

Code changes

  • src/App/Pages/CaptchaProtectedViewModel.cs: New base method to handle captcha. Older method didn't have any changes to protect other parts of the code that were using it. May be target of some tech dept to change to use the newer method.
  • src/Core/Services/CryptoService.cs: Added parameter to allow to rsa decrypt with a custom private key.

Screenshots

image

image

image

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from a team November 4, 2022 11:14
@andrebispo5 andrebispo5 requested a review from fedemkr November 8, 2022 12:51
@andrebispo5 andrebispo5 requested a review from fedemkr November 8, 2022 17:23
@andrebispo5 andrebispo5 marked this pull request as ready for review November 8, 2022 17:24
@andrebispo5 andrebispo5 requested a review from fedemkr November 8, 2022 23:10
@andrebispo5 andrebispo5 requested a review from fedemkr November 9, 2022 15:31
@andrebispo5 andrebispo5 merged commit 9ae269d into master Nov 9, 2022
@andrebispo5 andrebispo5 deleted the feature/SG-174-login-with-device branch November 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants