Skip to content

[SG-806] Mobile wrong environment endpoints crash#2173

Merged
andrebispo5 merged 1 commit intomasterfrom
bugfix/sg-806-wrong-environment-url
Nov 7, 2022
Merged

[SG-806] Mobile wrong environment endpoints crash#2173
andrebispo5 merged 1 commit intomasterfrom
bugfix/sg-806-wrong-environment-url

Conversation

@andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix bug. When the user is saving new environment endpoints and if one of them is wrong, the app will crash.

Code changes

Add try catch to LoginViewModel -> InitAsync method.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from a team November 6, 2022 11:30
@andrebispo5 andrebispo5 added the bug label Nov 6, 2022
@andrebispo5 andrebispo5 merged commit 8d92373 into master Nov 7, 2022
@andrebispo5 andrebispo5 deleted the bugfix/sg-806-wrong-environment-url branch November 7, 2022 13:41
andrebispo5 added a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants