[SG-808] Only show 'remove account' option if user is in Accounts list#2179
Merged
differsthecat merged 5 commits intomasterfrom Nov 10, 2022
Merged
[SG-808] Only show 'remove account' option if user is in Accounts list#2179differsthecat merged 5 commits intomasterfrom
differsthecat merged 5 commits intomasterfrom
Conversation
andrebispo5
requested changes
Nov 9, 2022
Member
|
@differsthecat @andrebispo5 shouldn't the password hint be removed from the More options? Given the new UI |
Member
Author
@fedemkr Yes, we had some discussions about this. To remove it we would have to make much deeper modifications in order to make the options only visible in certain cases. In order to get the actual issue fixed we are doing this for now but will create an issue to fully address this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Only show 'remove account' if the account already exists in the accounts list
Code changes
SavedEmailproperty that checks if the email belongs to an account in the accounts list and only showremove accountif they are there.Before you submit
dotnet format --verify-no-changes) (required)