Skip to content

[SG-808] Only show 'remove account' option if user is in Accounts list#2179

Merged
differsthecat merged 5 commits intomasterfrom
SG-808-2
Nov 10, 2022
Merged

[SG-808] Only show 'remove account' option if user is in Accounts list#2179
differsthecat merged 5 commits intomasterfrom
SG-808-2

Conversation

@differsthecat
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Only show 'remove account' if the account already exists in the accounts list

Code changes

  • src/App/Pages/Accounts/LoginPageViewModel.cs: Add SavedEmail property that checks if the email belongs to an account in the accounts list and only show remove account if they are there.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@differsthecat differsthecat requested a review from a team November 9, 2022 21:40
Copy link
Contributor

@andrebispo5 andrebispo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@fedemkr
Copy link
Member

fedemkr commented Nov 9, 2022

@differsthecat @andrebispo5 shouldn't the password hint be removed from the More options? Given the new UI

@differsthecat
Copy link
Member Author

@differsthecat @andrebispo5 shouldn't the password hint be removed from the More options? Given the new UI

@fedemkr Yes, we had some discussions about this. To remove it we would have to make much deeper modifications in order to make the options only visible in certain cases. In order to get the actual issue fixed we are doing this for now but will create an issue to fully address this.

@differsthecat differsthecat merged commit 0106732 into master Nov 10, 2022
@differsthecat differsthecat deleted the SG-808-2 branch November 10, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants