[SG-813] Not You? crashes app after vault logout timeout#2184
Merged
andrebispo5 merged 17 commits intomasterfrom Nov 11, 2022
Merged
[SG-813] Not You? crashes app after vault logout timeout#2184andrebispo5 merged 17 commits intomasterfrom
andrebispo5 merged 17 commits intomasterfrom
Conversation
fedemkr
requested changes
Nov 11, 2022
fedemkr
requested changes
Nov 11, 2022
fedemkr
previously approved these changes
Nov 11, 2022
fedemkr
previously approved these changes
Nov 11, 2022
fedemkr
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
If your account is set to logout on vault time-out, once your vault times out, if you click on “not you?” from the master password screen, the app crashes.
Steps to Reproduce:
Expected: Taken to email screen
Actual: App crashes
Code changes
Renamed HomePage parameter
checkRememberedEmailtocheckNavigateToLogin, also made the change on iOS Extensions.src/App/Utilities/AccountManagement/AccountsManager.cs:
HomePage.VaultTimeoutactions now navigates to theHomePagewith a set remembered email as the VaultTimeout account, and with redirect to login page. This allows the user to clickNot you?and go back to theHomePage.Screenshots
Before you submit
dotnet format --verify-no-changes) (required)