Skip to content

[SG-813] Not You? crashes app after vault logout timeout#2184

Merged
andrebispo5 merged 17 commits intomasterfrom
bugfix/SG-813-two-step-account-switch
Nov 11, 2022
Merged

[SG-813] Not You? crashes app after vault logout timeout#2184
andrebispo5 merged 17 commits intomasterfrom
bugfix/SG-813-two-step-account-switch

Conversation

@andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Nov 10, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If your account is set to logout on vault time-out, once your vault times out, if you click on “not you?” from the master password screen, the app crashes.

Steps to Reproduce:

  1. Login to account
  2. Set “vault timeout action” to “Logout”
  3. Let your vault timeout so it logs you out
  4. Click “not you?”

Expected: Taken to email screen

Actual: App crashes

Code changes

Renamed HomePage parameter checkRememberedEmail to checkNavigateToLogin, also made the change on iOS Extensions.

src/App/Utilities/AccountManagement/AccountsManager.cs:

  • Add account now navigates to HomePage.
  • VaultTimeout actions now navigates to the HomePage with a set remembered email as the VaultTimeout account, and with redirect to login page. This allows the user to click Not you? and go back to the HomePage.

Screenshots

IMG_5730
IMG_5731
IMG_2CC606322E06-1

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from a team November 10, 2022 15:50
@andrebispo5 andrebispo5 requested a review from fedemkr November 11, 2022 16:39
fedemkr
fedemkr previously approved these changes Nov 11, 2022
fedemkr
fedemkr previously approved these changes Nov 11, 2022
@andrebispo5 andrebispo5 merged commit 7e8e86a into master Nov 11, 2022
@andrebispo5 andrebispo5 deleted the bugfix/SG-813-two-step-account-switch branch November 11, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants