Skip to content

Changed Github deployments not to trigger on Dry Run#2188

Merged
trmartin4 merged 1 commit intomasterfrom
workflow/remove-github-deployment-on-dry-run
Nov 14, 2022
Merged

Changed Github deployments not to trigger on Dry Run#2188
trmartin4 merged 1 commit intomasterfrom
workflow/remove-github-deployment-on-dry-run

Conversation

@trmartin4
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The Github deployment was getting created (and sent to Jira) for Dry Run triggers.

Code changes

  • release.yml: Added check to only run Deployment-related jobs when it is not a Dry Run

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@trmartin4 trmartin4 requested a review from a team November 12, 2022 22:43
@trmartin4 trmartin4 merged commit 1b137a8 into master Nov 14, 2022
@trmartin4 trmartin4 deleted the workflow/remove-github-deployment-on-dry-run branch November 14, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants