[SG-778] Adjust mobile client to handle previously-responded-to passwordless request#2190
Merged
andrebispo5 merged 5 commits intomasterfrom Nov 15, 2022
Merged
Conversation
fedemkr
requested changes
Nov 14, 2022
Comment on lines
+182
to
+184
| public bool? Approved { get; set; } | ||
|
|
||
| public DateTime? ResponseDate { get; set; } |
Member
There was a problem hiding this comment.
I don't see these properties being used anywhere; just being set. Can they be removed?
Contributor
Author
There was a problem hiding this comment.
Yes they can, initially i was passing them on constructor of the page, but them realised i had to call the method to get the login request on button click.
fedemkr
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #bitwarden/server#2412
Type of change
Objective
When responding to a previously answered passwordless device, show a message saying the request is not longer valid.
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)