Skip to content

[SG-816] Get all login requests and pick the most recent#2191

Merged
andrebispo5 merged 7 commits intomasterfrom
bugfix/SG-816-login-request-sync
Nov 15, 2022
Merged

[SG-816] Get all login requests and pick the most recent#2191
andrebispo5 merged 7 commits intomasterfrom
bugfix/SG-816-login-request-sync

Conversation

@andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Nov 15, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If the user for some reason did not receive the notification to login with the device, sync the vault will fetch all login requests and pick the most recent and valid one.

Code changes

  • SyncService.cs: when vault sync is triggered, get all login requests and set in the stateService the most recent. After that triggers a normal passwordless login request flow.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from a team November 15, 2022 10:43
@andrebispo5 andrebispo5 requested a review from fedemkr November 15, 2022 14:44
@andrebispo5 andrebispo5 requested a review from fedemkr November 15, 2022 17:13
@andrebispo5 andrebispo5 merged commit 693a4ef into master Nov 15, 2022
@andrebispo5 andrebispo5 deleted the bugfix/SG-816-login-request-sync branch November 15, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants