[SG-831] Pull Down Sync does not retrieve pending AuthRequests#2196
Merged
andrebispo5 merged 3 commits intomasterfrom Nov 17, 2022
Merged
[SG-831] Pull Down Sync does not retrieve pending AuthRequests#2196andrebispo5 merged 3 commits intomasterfrom
andrebispo5 merged 3 commits intomasterfrom
Conversation
fedemkr
approved these changes
Nov 17, 2022
trmartin4
pushed a commit
that referenced
this pull request
Nov 17, 2022
* [SG-831] Pull to refresh forces refresh. * [SG-831] Expose sync login request method to be used independently * [SG-831] Change sync order (cherry picked from commit 34fd30e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Adding the possibility to manually get pending login requests. This will be always fetched even though the sync is not forced.
Code changes
Exposed the Sync Login Requests method to be called separately from the FullSync. This is a temporary solution. A tech dept ticket was created to move all Passwordless code to an independent service.
Before you submit
dotnet format --verify-no-changes) (required)