Skip to content

[SG-860] Add condition to execute notification tap code#2211

Merged
andrebispo5 merged 1 commit intomasterfrom
bugfix/SG-860-notif-tap
Dec 1, 2022
Merged

[SG-860] Add condition to execute notification tap code#2211
andrebispo5 merged 1 commit intomasterfrom
bugfix/SG-860-notif-tap

Conversation

@andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Tapping the login request notification before the modal showed up, was launching a new window and the modal would never appear

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested review from a team December 1, 2022 09:54
@andrebispo5 andrebispo5 merged commit f43f917 into master Dec 1, 2022
@andrebispo5 andrebispo5 deleted the bugfix/SG-860-notif-tap branch December 1, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants