Skip to content

[SG-870] Android notification not showing when app is killed#2221

Merged
andrebispo5 merged 1 commit intomasterfrom
bugfix/SG-870-notification-not-show
Dec 13, 2022
Merged

[SG-870] Android notification not showing when app is killed#2221
andrebispo5 merged 1 commit intomasterfrom
bugfix/SG-870-notification-not-show

Conversation

@andrebispo5
Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If the user receives a passwordless login request and the application is not running on foreground or background the notification will not be shown.
This is due to an if condition to check if there is already a login request modal being presented to the user.

Code changes

Added null check on App.Current. This is null when the app is killed.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested review from a team December 5, 2022 10:21
@andrebispo5 andrebispo5 changed the title [SG-870] Add null check on notification received [SG-870] Android notification not showing when app is killed Dec 5, 2022
@andrebispo5 andrebispo5 merged commit f4b4cfc into master Dec 13, 2022
@andrebispo5 andrebispo5 deleted the bugfix/SG-870-notification-not-show branch December 13, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants