[EC-628] Added Crashlytics to the watchOS project#2267
Merged
Conversation
…e-Info.plist for now
…list for Crashlytics and also added step to upload Watch dSYMs to Crashlytics
…h XCode dependencies correctly with SPM
…wrong path. Also deactivated droid builds so that it's faster to test and doesn't consume resources on that till the build is OK
…r that was causing the build to fail
… and added some logs to find the upload-symbols tool from SPM. Also fix making the dir for the watchOS dSYMs export path
…the upload-symbols script dynamically with find and then executing it
…ring back droid builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add Firebase Crashlytics to the watchOS project so that we have crash reporting. AppCenter doesn't support watchOS that's why we are implementing the other one.
Code changes
WKExtensionDelegateAdaptorfirebase-ios-sdkpackage and theCrashlyticsproduct.runs-ontomacos-12in order to use newer XCode that can resolve dependencies using current schema for Swift Package Manager.GoogleService-Info.plistneeded for Firebase config.findto get theupload-symbolsscript and execute it afterwards; this should be improved, but for now it works.Before you submit
dotnet format --verify-no-changes) (required)