[PS-2162] Add needs-qa label to enforce-labels workflow#2274
Merged
[PS-2162] Add needs-qa label to enforce-labels workflow#2274
needs-qa label to enforce-labels workflow#2274Conversation
aj-rosado
approved these changes
Jan 3, 2023
vgrassia
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
I realized via bitwarden/mobile#2044 that we do not block merging when the
needs-qa-label was added.The enforcement on the
needs-qalabel was added with bitwarden/clients#3450 for the clients and with bitwarden/server#2248 for the server, but we must have missed the mobile repo.Code changes
needs-qato the BANNED_LABELS and mentioned it in the description.Before you submit
dotnet format --verify-no-changes) (required)