Skip to content

[EC-763] Cake build watchOS#2278

Merged
fedemkr merged 7 commits intomasterfrom
EC-763-cake-build-watchos
Feb 20, 2023
Merged

[EC-763] Cake build watchOS#2278
fedemkr merged 7 commits intomasterfrom
EC-763-cake-build-watchos

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 5, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implemented watchOS parts on cake build and iOS / watchOS icons update

Code changes

  • build.cake: Added replacement of bundle id and version on watchOS related files. I couldn't find a Cake extension to handle pbxproj files so I just replace by using a regex. Also added icons update for iOS and watchOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr requested review from a team and vvolkgang January 5, 2023 21:46
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small improvement but everything else looks great!

@fedemkr fedemkr requested a review from vvolkgang January 10, 2023 23:23
@fedemkr fedemkr merged commit b26b9ea into master Feb 20, 2023
@fedemkr fedemkr deleted the EC-763-cake-build-watchos branch February 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants