[SG-912] Modify the mobile app to retrieve the user's avatar color#2284
Merged
BrandonM-Bitwarden merged 2 commits intomasterfrom Jan 12, 2023
Merged
[SG-912] Modify the mobile app to retrieve the user's avatar color#2284BrandonM-Bitwarden merged 2 commits intomasterfrom
BrandonM-Bitwarden merged 2 commits intomasterfrom
Conversation
…2277) * work: baseline * fix: dont use profile for store * fiix: use userid in key * fix: lookup on AccountView list create * fix my own bad advice + tweaks * Autosync the updated translations (#2279) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * fix my own bad advice + tweaks * fiix: use userid in key * [PS-1352] Fix ignore diacritics in search (#2044) * Fix ignore diacritics in search This change updates the search function to ignore diacritical marks in search results. Marks are stripped from both the search input and results. * Removed logs, added null or whitespace validation and improved formatting Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> Co-authored-by: Andre Rosado <arosado@bitwarden.com> * [PS-2145] add rainsee browser series support (#2272) * fix: lookup on AccountView list create * Autosync the updated translations (#2279) Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> * fix my own bad advice + tweaks Co-authored-by: mp-bw <59324545+mp-bw@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> Co-authored-by: noncenz <33376717+noncenz@users.noreply.github.com> Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> Co-authored-by: Andre Rosado <arosado@bitwarden.com> Co-authored-by: Auj625197595 <32589249+Auj625197595@users.noreply.github.com>
BrandonM-Bitwarden
changed the title
mpbw2
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Signed branch of https://github.com/bitwarden/mobile/pull/2277/files
Code changes
~src/App/Controls/AccountViewCell/AccountViewCellViewModel.cs: Added new field to avatar builder
~src/App/Controls/AvatarImageSource.cs: Added new field
~src/App/Controls/AvatarImageSourcePool.cs: Added new cache key value
~src/App/Pages/BaseContentPage.cs: adjusted state getter to pull once and for avatar
~src/App/Pages/BaseContentPage.cs: added refresh for avatar
~src/Core/Abstractions/IStateService.cs: Added new methods
~src/Core/Models/Domain/Account.cs: Added new field
~src/Core/Models/Response/ProfileResponse.cs: Added new field
~src/Core/Models/View/AccountView.cs: Added new field
~src/Core/Services/StateService.cs: Addded getters from profile
~src/Core/Services/SyncService.cs: added save for profile on sync
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)