Skip to content

[SG-744] Add claimed domain logic to mobile#2333

Merged
andrebispo5 merged 12 commits intomasterfrom
feature/SG-744-domain-claiming
Feb 20, 2023
Merged

[SG-744] Add claimed domain logic to mobile#2333
andrebispo5 merged 12 commits intomasterfrom
feature/SG-744-domain-claiming

Conversation

@andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Jan 30, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Now that we have the ability for domain admins to claim domains, this task will add the logic to each of the clients - which have already had Two-Step Login added - to check the API for the provided domain name on the first step of the login process to see how to handle SSO:
When a domain has been claimed by an organization the “Enterprise Single Sign-On” button on step 2 takes the user directly to the domain specific SSO action and does not require them to enter an org identifier.

Code changes

Add new method to check if the email has an SSO domain claimed.
On login with SSO, in the Init check if the the email has a claimed SSO Domain and automatically jump to the Login.
Note: Due to the difficulty of testing this locally, the code of this new feature will be tested by the QA team and fixes will be done afterwards

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from a team January 30, 2023 16:42
@andrebispo5 andrebispo5 requested a review from fedemkr January 30, 2023 18:47
@andrebispo5 andrebispo5 requested a review from fedemkr January 30, 2023 21:15
fedemkr
fedemkr previously approved these changes Jan 30, 2023
@andrebispo5
Copy link
Contributor Author

Added new state variable to hold the pre login email to be used in the SSO login page. This was done because there was a case in BaseLockPasswordViewController where it was difficult to pass the email through navigation.

@andrebispo5 andrebispo5 requested a review from fedemkr February 17, 2023 11:21
@andrebispo5
Copy link
Contributor Author

Updated error handling after discussion with the QA team and it was decided to fix web form validations.

@andrebispo5 andrebispo5 requested a review from fedemkr February 17, 2023 16:16
@andrebispo5 andrebispo5 merged commit 3f72d35 into master Feb 20, 2023
@andrebispo5 andrebispo5 deleted the feature/SG-744-domain-claiming branch February 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants