[SG-744] Add claimed domain logic to mobile#2333
Merged
andrebispo5 merged 12 commits intomasterfrom Feb 20, 2023
Merged
Conversation
fedemkr
requested changes
Jan 30, 2023
fedemkr
requested changes
Jan 30, 2023
fedemkr
previously approved these changes
Jan 30, 2023
Contributor
Author
|
Added new state variable to hold the pre login email to be used in the SSO login page. This was done because there was a case in |
fedemkr
requested changes
Feb 14, 2023
Contributor
Author
|
Updated error handling after discussion with the QA team and it was decided to fix web form validations. |
fedemkr
requested changes
Feb 17, 2023
fedemkr
requested changes
Feb 17, 2023
fedemkr
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Now that we have the ability for domain admins to claim domains, this task will add the logic to each of the clients - which have already had Two-Step Login added - to check the API for the provided domain name on the first step of the login process to see how to handle SSO:
When a domain has been claimed by an organization the “Enterprise Single Sign-On” button on step 2 takes the user directly to the domain specific SSO action and does not require them to enter an org identifier.
Code changes
Add new method to check if the email has an SSO domain claimed.
On login with SSO, in the Init check if the the email has a claimed SSO Domain and automatically jump to the Login.
Note: Due to the difficulty of testing this locally, the code of this new feature will be tested by the QA team and fixes will be done afterwards
Before you submit
dotnet format --verify-no-changes) (required)