Add YubiKey keyboard support by alistair23 · Pull Request #248 · bitwarden/android

alistair23 · 2018-01-09T02:39:00Z

No description provided.

kspearrin · 2018-01-12T01:53:58Z

src/App/Pages/LoginTwoFactorPage.cs

Other platforms do not need this cell since they listen to NFC.

Also, no need for the placeholder string. UI should follow how it is in the browser extension.

It is also possible to use the USB entry on Android, if you don't have NFC support, which is why I was adding the option. I will update the interface though.

https://www.yubico.com/support/knowledge-base/categories/articles/can-yubikey-4c-plugged-directly-android-phones-tablets-usb-c-ports/

kspearrin · 2018-01-12T01:54:06Z

src/App/Pages/LoginTwoFactorPage.cs

GitHub wants me to comment here as well. Same as above, USB entry does work on Android so I think it makes sense to leave it in. If you really want I can remove it on Android though.

kspearrin · 2018-01-12T01:56:55Z

src/App/Pages/LoginTwoFactorPage.cs

You dont need parens around your UWP check. Also dont you need some kind of "Has USB Port" check?

alistair23 · 2018-01-12T07:36:22Z

I updated it, I tried to detect USB support, but it seems really hard to do. USB is a mess. It also seems unlikely that a Windows 10 computer doesn't have a USB port. This is my dev branch: https://github.com/alistair23/bytewarden-windows/tree/alistair/yubikey-wip

kspearrin · 2018-01-12T13:55:51Z

Yes, but UWP is for mobile devices too. Do all windows mobile devices support USB?

alistair23 · 2018-01-12T17:01:02Z

This app doesn't support Windows for phones, so that isn't a huge issue.

I was thinking about this more though. So this app does support Xbox and maybe some future phone thing that Microsoft does. So there is merit in checking for USB. In saying that it is really hard to do. For example on my Surface Pro 2 the built-in camera is connected via USB, so the check will be a false positive there. I don't think it's unreasonable to assume that a device has a USB port, that isn't too unrealistic. If the user can't use it then they can change the second factor option.

alistair23 · 2018-01-12T21:32:40Z

It also occurred to me that the Xbox One does has USB ports and I'm pretty sure it supports USB keyboards. So there really isn't much that doesn't support USB input.

kspearrin · 2018-01-15T02:31:26Z

Wait, so UWP apps don't run on any type of mobile phones?

alistair23 · 2018-01-15T03:09:44Z

There is no Windows Phone OS that runs with .NET standard 2.0. The latest and last Windows Phone OS is the fall creators update, which doesn't run .NET standard 2.0. This is why I had to create a fork, because Microsoft dropped the platform.

alistair23 · 2018-01-15T03:10:39Z

Unless some unannounced OS comes up this can't support a Windows Phone

kspearrin · 2018-01-15T04:50:31Z

But aren't there mobile phones that run windows 10? If not, I am struggling to understand why we should even support UWP through the mobile project going forward. We will have a desktop app in a month or two.

alistair23 · 2018-01-15T04:59:48Z

There are no mobile phones that run a Windows OS that bitwarden can run on. UWP is good for Windows S and Xbox as well as regular Windows.

alistair23 · 2018-01-15T05:00:23Z

My fork can run on Windows Phones though

kspearrin · 2018-01-17T13:35:39Z

src/App/Resources/AppResources.resx

Should read:

To continue, hold your YubiKey NEO against the back of the device or insert your YubiKey into your device's USB port, then touch its button.

kspearrin · 2018-01-17T13:36:46Z

src/App/Pages/LoginTwoFactorPage.cs

AppResources.YubiKeyTextEnter This text can go away to be consistent with the browser extension. It is blank.

Also, is this field auto-focused?

Signed-off-by: Alistair Francis <alistair@alistair23.me>

On Android and UWP it's possible to use the YubiKey to enter text instead of using the NFC. Allow people to do that. Signed-off-by: Alistair Francis <alistair@alistair23.me>

Windows platforms should always have YubiKey support. Signed-off-by: Alistair Francis <alistair@alistair23.me>

alistair23 · 2018-01-18T06:34:27Z

All updated again

* App: Pages: Fix the YubiKey image source Signed-off-by: Alistair Francis <alistair@alistair23.me> * App: Allow YubiKey keyboard output on apps On Android and UWP it's possible to use the YubiKey to enter text instead of using the NFC. Allow people to do that. Signed-off-by: Alistair Francis <alistair@alistair23.me> * App: Pages: Enable YubiKey support on Windows platforms Windows platforms should always have YubiKey support. Signed-off-by: Alistair Francis <alistair@alistair23.me>

kumarharsh · 2018-01-23T11:04:29Z

Kinda bummed that phones won't be supported ☹ But it'd be a huge help if XBox does get the app - as inputting auto-generated passwords with a controller are a major PITA!

Also, just to be clear regarding Windows support:

The official Bitwarden app can't run on Windows 10 Mobile (which is stuck on Creators Update more or less).
There is a fork maintained by @alistair23 which does run on Windows 10 Mobile.
The official Bitwarden app can run on Windows 10 S and XBox.
The official Bitwarden app will run on any future phone-like devices which run Windows 10/Andromeda.

Am I right in these assumptions?

alistair23 · 2018-01-23T16:54:27Z

Correct
Correct. This does run on Xbox, although the Xbox has no copy/paste support so it isn't super useful.
At the moment yes.
In theory yes

alistair23 force-pushed the alistair/yubikey branch 2 times, most recently from 8531f4b to 8536695 Compare January 9, 2018 16:16

kspearrin requested changes Jan 12, 2018

View reviewed changes

alistair23 force-pushed the alistair/yubikey branch 2 times, most recently from a2728ed to b3e2298 Compare January 12, 2018 07:35

kspearrin reviewed Jan 17, 2018

View reviewed changes

alistair23 added 3 commits January 17, 2018 22:28

App: Pages: Fix the YubiKey image source

4b37e6f

Signed-off-by: Alistair Francis <alistair@alistair23.me>

App: Allow YubiKey keyboard output on apps

ecadc92

On Android and UWP it's possible to use the YubiKey to enter text instead of using the NFC. Allow people to do that. Signed-off-by: Alistair Francis <alistair@alistair23.me>

App: Pages: Enable YubiKey support on Windows platforms

ede8a4d

Windows platforms should always have YubiKey support. Signed-off-by: Alistair Francis <alistair@alistair23.me>

alistair23 force-pushed the alistair/yubikey branch from b3e2298 to ede8a4d Compare January 18, 2018 06:29

kspearrin approved these changes Jan 18, 2018

View reviewed changes

kspearrin merged commit 3f31d78 into bitwarden:master Jan 18, 2018

alistair23 deleted the alistair/yubikey branch January 18, 2018 17:10

vvolkgang pushed a commit that referenced this pull request Jun 20, 2024

Add IME padding to create account screen (#248)

b0ea7a4

UCan927 pushed a commit to UCan927/BitWarden-Android that referenced this pull request Jun 22, 2024

Add IME padding to create account screen (bitwarden#248)

3e6ce66

vvolkgang pushed a commit that referenced this pull request Feb 26, 2025

BITAU-78 Show SyncWithBitwarden action card (#248)

ab4d9b9

Conversation

alistair23 commented Jan 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alistair23 commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kspearrin commented Jan 12, 2018

Uh oh!

alistair23 commented Jan 12, 2018

Uh oh!

alistair23 commented Jan 12, 2018

Uh oh!

kspearrin commented Jan 15, 2018

Uh oh!

alistair23 commented Jan 15, 2018

Uh oh!

alistair23 commented Jan 15, 2018

Uh oh!

kspearrin commented Jan 15, 2018

Uh oh!

alistair23 commented Jan 15, 2018

Uh oh!

alistair23 commented Jan 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alistair23 commented Jan 18, 2018

Uh oh!

kumarharsh commented Jan 23, 2018

Uh oh!

alistair23 commented Jan 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alistair23 commented Jan 12, 2018 •

edited

Loading