Skip to content

[PM-2313] Allow empty passphrase separator#2526

Closed
joseph082 wants to merge 3 commits intobitwarden:mainfrom
joseph082:feature/allow-empty-passphrase-separator
Closed

[PM-2313] Allow empty passphrase separator#2526
joseph082 wants to merge 3 commits intobitwarden:mainfrom
joseph082:feature/allow-empty-passphrase-separator

Conversation

@joseph082
Copy link

@joseph082 joseph082 commented May 19, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Closes #2525
Allow empty passphrase word separator in passphrase generator

Code changes

  • PasswordGenerationService.cs: Removed the check for an empty wordSeparator where currently, it is defaulted to a space. Now, the wordSeparator will remain as the empty string.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-2313

@bitwarden-bot bitwarden-bot changed the title Allow empty passphrase separator [PM-2313] Allow empty passphrase separator May 19, 2023
@joseph082 joseph082 requested a review from a team as a code owner January 31, 2024 03:18
@bitwarden-bot
Copy link

bitwarden-bot commented Jan 31, 2024

Logo
Checkmarx One – Scan Summary & Detailsa7c93648-f533-4b7f-a8e5-034334829308

No New Or Fixed Issues Found

@micahblut
Copy link
Member

micahblut commented Mar 27, 2024

Will not implement - this has been implemented in the upcoming native apps, so this particular PR is no longer needed. Thank you for your contribution @joseph082 !

@micahblut micahblut closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passphrase generation disallows empty word separator

3 participants