Skip to content

[PM-2544] Adding AutomationIDs for CipherAddEditViewPage elements#2564

Merged
ifernandezdiaz merged 4 commits intomasterfrom
PM-2544/adding-ids-on-CipherAddEditPage
Jun 14, 2023
Merged

[PM-2544] Adding AutomationIDs for CipherAddEditViewPage elements#2564
ifernandezdiaz merged 4 commits intomasterfrom
PM-2544/adding-ids-on-CipherAddEditPage

Conversation

@ifernandezdiaz
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • CipherAddEditPage.xaml: Adding locators for all the Login/Card/SecureNote/Identity item fields
  • TextCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • BooleanCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • HiddenCustomFieldItemLayout.xaml: Adding locators for title/value fields
  • LinkedCustomFieldItemLayout.xaml: Adding locators for title/value fields

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs to retain those spaces so our formatter is happy

@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 13, 2023 15:17
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 13, 2023 19:25
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ifernandezdiaz ifernandezdiaz merged commit 52843b4 into master Jun 14, 2023
@ifernandezdiaz ifernandezdiaz deleted the PM-2544/adding-ids-on-CipherAddEditPage branch June 14, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants