Skip to content

Adding AutomationIDs on Generator page elements#2569

Merged
ifernandezdiaz merged 2 commits intomasterfrom
PM-2610/add-automationIDs-for-generator-page-elements
Jun 15, 2023
Merged

Adding AutomationIDs on Generator page elements#2569
ifernandezdiaz merged 2 commits intomasterfrom
PM-2610/add-automationIDs-for-generator-page-elements

Conversation

@ifernandezdiaz
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • GeneratorPage.xaml: Adding IDs for all the interactable elements displayed for passwords/usernames
  • GeneratorPageHistory.xaml: Adding IDs for each cell, apart from the locators for each nested element

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@ifernandezdiaz ifernandezdiaz changed the title Adding AutomationIDs on Generator pages Adding AutomationIDs on Generator page elements Jun 15, 2023
@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 15, 2023 16:58
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 15, 2023 18:54
@ifernandezdiaz ifernandezdiaz merged commit bc5c11b into master Jun 15, 2023
@ifernandezdiaz ifernandezdiaz deleted the PM-2610/add-automationIDs-for-generator-page-elements branch June 15, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants