Skip to content

[PM-2737] Adding AutomationIDs for Send page elements#2583

Merged
ifernandezdiaz merged 9 commits intomasterfrom
PM-2737/automationIDs-for-send-page-elements
Jun 28, 2023
Merged

[PM-2737] Adding AutomationIDs for Send page elements#2583
ifernandezdiaz merged 9 commits intomasterfrom
PM-2737/automationIDs-for-send-page-elements

Conversation

@ifernandezdiaz
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • SendAddEditPage.xaml: Adding IDs for each Send element
  • SendGroupingsPage.xaml: Adding IDs for Send lists
  • SendGroupingsPageListItem.xaml: Adding a new variable to make AutomationIDs dynamic
  • SendsPage.xaml: Adding IDs for label displayed when send list is empty

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 23, 2023 14:09
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 23, 2023 14:42
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for input on #2580 since it follows the same approach

@ifernandezdiaz ifernandezdiaz requested a review from fedemkr June 23, 2023 16:39
….com:bitwarden/mobile into PM-2737/automationIDs-for-send-page-elements
@ifernandezdiaz ifernandezdiaz requested a review from fedemkr June 27, 2023 16:56
@ifernandezdiaz ifernandezdiaz enabled auto-merge (squash) June 27, 2023 17:26
@ifernandezdiaz ifernandezdiaz requested a review from mpbw2 June 27, 2023 19:20
@ifernandezdiaz ifernandezdiaz merged commit 216c6ab into master Jun 28, 2023
@ifernandezdiaz ifernandezdiaz deleted the PM-2737/automationIDs-for-send-page-elements branch June 28, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants