Skip to content

[AC-1425] Fix iOS blank vault load#2604

Merged
fedemkr merged 2 commits intomasterfrom
vault/ac-1425-fix-ios-pull-to-refresh
Jul 17, 2023
Merged

[AC-1425] Fix iOS blank vault load#2604
fedemkr merged 2 commits intomasterfrom
vault/ac-1425-fix-ios-pull-to-refresh

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 7, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR attempts to fix an issue happening from time to time, where the vault view's list doesn't load
Even though I couldn't reproduce the issue, I forced in the code the properties not to propagate changes to the view which end in this state, and based on these assumptions this fix is presented.

Code changes

  • GroupingPageViewModel: Added a bunch of main thread invocations for the properties expected to change from the view, so in case there is another thread executing the load, the property changed will be invoked in the main thread.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

…ies to fix cases where the screen stays blank and doesn't update
@fedemkr fedemkr requested review from a team July 7, 2023 18:47
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 7, 2023

Logo
Checkmarx One – Scan Summary & Details48994c5b-0aed-4b43-865d-ef1373997a14

No New Or Fixed Issues Found

Copy link
Member

@LRNcardozoWDF LRNcardozoWDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedemkr fedemkr merged commit cd9e49b into master Jul 17, 2023
@fedemkr fedemkr deleted the vault/ac-1425-fix-ios-pull-to-refresh branch July 17, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants