Skip to content

[PM-2900] Added two extra dark themes options DarkPlus and SolarizedDarkBlue#2605

Closed
KeshavPratap-K wants to merge 4 commits intobitwarden:masterfrom
KeshavPratap-K:Additional-Dark-themes-for-mobile-app
Closed

[PM-2900] Added two extra dark themes options DarkPlus and SolarizedDarkBlue#2605
KeshavPratap-K wants to merge 4 commits intobitwarden:masterfrom
KeshavPratap-K:Additional-Dark-themes-for-mobile-app

Conversation

@KeshavPratap-K
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

These two need dark themes are added to give Bitwarden mobile app a refreshed look. One DarkPlus is inspired from GitHub dark mode and Solarized DarkBlue is inspired from existing Solarized Dark theme to be in blue.

Code changes

  • ThemeHelpers.cs - Added conditions to existing code to make light theme specific style false as added two themes are dark mode theme.
  • OptionsPageViewModel.cs - Added Values to existing theme selector in options page.
  • AppResources.Designer.cs - System generated due to changes made in below file.
  • AppResources.resx - Added Value to display and comment for new theme in option menu.
  • DarkPlus.xaml - DarkPlus theme style definition.
  • DarkPlus.xaml.cs - To initialize DarkPlus theme.
  • SolarizedDarkBlue.xaml - Solarized DarkBlue theme style definition.
  • SolarizedDarkBlue.xaml.cs - To initialize Solarized DarkBlue theme.
  • ThemeManager.cs - Code to change theme style for added themes. Used existing functions.

Screenshots

Dark+ LoginPage

Solarized DarkBlue LoginPage

Dark+ Password

Solarized DarkBlue Password

Dark+ Password generator

[olarized DarkBlue Password generator

Dark+ HomePage

Solarized DarkBlue HomePage

Options theme Value Dark+

Options theme Value Solarized DarkBlue

Settings

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2023

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-2900

@bitwarden-bot bitwarden-bot changed the title Added two extra dark themes options DarkPlus and SolarizedDarkBlue [PM-2900] Added two extra dark themes options DarkPlus and SolarizedDarkBlue Jul 8, 2023
@djsmith85 djsmith85 closed this Aug 15, 2023
@djsmith85
Copy link
Contributor

Closed as per this comment from @dwbit in the related contribution proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants