[PM-2901] Synchronize sends on send creation/update/deletion notification#2606
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
There was a problem hiding this comment.
Thank you for your contribution @quexten , I really appreciate your work on this
I'd like to request a minor adjustment in the notification type validation.
While the code follows Cipher's logic, I have a few suggestions to further enhance readability and reduce indentation. If you could implement these changes, I would be sincerely grateful! 😃
Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com>
aj-rosado
left a comment
There was a problem hiding this comment.
Thank you for your efforts cleaning the code 👏
Just requesting two more changes.
Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com>
aj-rosado
left a comment
There was a problem hiding this comment.
Looking good! Thank you for your contribution and the efforts in improving it.
Sending to QA 🎉
aj-rosado
left a comment
There was a problem hiding this comment.
Reapproving it, just committed a minor fix on whitespace.
|
Thank you for your contribution @quexten! This has been merged and will be part of a future release! 🎉 🥳 |
Type of change
Objective
Fixes #2571. On desktop/web, sends are synced when the Websocket notification notifying the clients of the creation/update/deletion arrives. On mobile this is not implemented. This PR brings feature parity in that regard by implementing syncing send creation/updates/deletions on arrival of the Firebase notification.
Beware, I was not able to fully test this as the default config builds for the QA push environment.
Code changes
Before you submit
dotnet format --verify-no-changes) (required)