[PM-2320] Improve Android block Auto-fill URIs#2616
Merged
Conversation
|
No New Or Fixed Issues Found |
|
@Federico-Maccaroni is there a way to embed the color variables from the theme file into the SVG? That way it will appear nicely in each theme. |
LRNcardozoWDF
previously approved these changes
Jul 17, 2023
Member
LRNcardozoWDF
left a comment
There was a problem hiding this comment.
Nice job @fedemkr, LGTM.
mpbw2
approved these changes
Jul 17, 2023
mpbw2
reviewed
Jul 20, 2023
| <data name="NewBlockedURI" xml:space="preserve"> | ||
| <value>New blocked URI</value> | ||
| </data> | ||
| <data name="URISaved" xml:space="preserve"> |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type of change
Objective
Improve current way to block Auto-fill URIs. This is an Android feature.
Code changes
DisplayValidatablePromptAsync(...)method that shows a custom alert dialog with a custom view that has validations and execute the validations when pressingsave. The dialog is dismissed onsaveonly when all validations are valid. Also, added a few improvements for accessibility.validatable_input_dialog_layout.xmlDeviceActionService.DisplayValidatablePromptAsync. Chose struct over method parameters to have more flexibility and because they are a lot.Screenshots
Options Block autofill light
Options Block autofill dark
Block autofill empty light
Block autofill empty dark
Block autofill multiple items light
Block autofill multiple items dark
Block autofill new uri
Block autofill new uri error
Block Autofill edit uri
Before you submit
dotnet format --verify-no-changes) (required)