[PM-3092] Clarify argon2 ios autofill warning#2630
Merged
mpbw2 merged 3 commits intobitwarden:masterfrom Aug 7, 2023
Merged
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
mpbw2
requested changes
Aug 7, 2023
mpbw2
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
#2560 Added a warning for iOS users since iOS autofill might crash with too high memory usage caused by argon2. This PR clarifies the message by adding biometric unlock as another option to resolve the issue. When using biometrics to unlock, the KDF is circumvented entirely and thus the issue does not occur (without the user changing their KDF settings).
Code changes
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)