[PM-2408] Pending admin approval requests#2643
[PM-2408] Pending admin approval requests#2643andrebispo5 merged 17 commits intoauth/pm-2293-tde-auth-requestsfrom
Conversation
andrebispo5
changed the base branch from
master
to
auth/pm-2293-tde-auth-requests
|
No New Or Fixed Issues Found |
| PasswordlessLoginResponse response = null; | ||
| if (await _stateService.IsAuthenticatedAsync()) | ||
| { | ||
| response = await _authService.GetPasswordlessLoginRequestByIdAsync(_requestId); |
There was a problem hiding this comment.
Now that I'm looking at this, we should probably indicate that this requires authentication whereas the other one doesn't
There was a problem hiding this comment.
So far, we don't have any standard to indicate that endpoint need authentication. Should we place a method comment/doc for the GetPasswordlessLoginRequestByIdAsync?
There was a problem hiding this comment.
Considering you can't get any device auth requests using this method, we might want to rename it to be GetAdminAuthRequest or something similar. We might expand it in the future, but lets make it a little more specific for now.
There was a problem hiding this comment.
This method is also used for the Login With Device it is not specific to the admin requests.
jlf0dev
left a comment
jlf0dev
left a comment
There was a problem hiding this comment.
Looks good to me, I'll let Fede give final approval
* [PM-1208] Add navigation to device approval options after 2FA auth when TDE is enabled * [PM-1208] Add navigations to iOS extensions
Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
4 participants
Merge after bitwarden/mobile#2642
Type of change
Objective
Reuse created admin requests when trying to approve a login with TDE Admin approval request.
Code changes
Store admin request id and private key to secure storage.
When opening the screen check for pending admin requests.
If there is a pending admin request populate the vm data with the saved request.
Screenshots
Screen.Recording.2023-07-25.at.17.15.11.mov
Before you submit
dotnet format --verify-no-changes) (required)