[PM-3165] Fix custom block URI dialog cancellation#2647
Merged
Conversation
…ing on the background.
|
No New Or Fixed Issues Found |
mpbw2
reviewed
Jul 27, 2023
|
|
||
| var result = new TaskCompletionSource<ValidatablePromptResponse?>(); | ||
|
|
||
| alertBuilder.SetOnCancelListener(new BasicDialogWithResultCancelListener(result)); |
Contributor
There was a problem hiding this comment.
Just curious, why not just use the same (sender, args) => result.TrySetResult(null) as the negative listener? Is it preventing the dialog from dismissing properly?
Member
Author
There was a problem hiding this comment.
The negative listener is for the "cancel" button of the dialog and the SetOnCancelListener is for when the user taps in the background to dismiss the dialog. Currently, there is no EventHandler property to use the form (sender, args) => result.TrySetResult(null) so that's why I implemented a custom class for the listener.
mpbw2
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix custom block URI dialog cancellation to finish its internal task and not block the button.
Code changes
BasicDialogWithResultCancelListenerto handle dialog cancellation and set the return task value tonullso that the task gets finished when the user taps in the background to cancel the opened dialog.Before you submit
dotnet format --verify-no-changes) (required)