Skip to content

[PM-3298] Updated region selector naming#2657

Merged
fedemkr merged 2 commits intomasterfrom
vault/pm-3298/update-region-selector
Aug 4, 2023
Merged

[PM-3298] Updated region selector naming#2657
fedemkr merged 2 commits intomasterfrom
vault/pm-3298/update-region-selector

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Aug 3, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update region selector naming

Code changes

  • HomePageViewModel: Changed "Region" and "Data Region" for "Logging in on" and also changed the "US"/"EU" options for more specific naming.

Screenshots

Home view Android

Home view Android

Logging in on picker Android

Logging in on picker Android

Home view iOS

Home view iOS

Logging in on picker iOS

Logging in on picker iOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr requested a review from a team August 3, 2023 19:53
@fedemkr fedemkr removed the needs-qa label Aug 4, 2023
@fedemkr fedemkr merged commit c34d1da into master Aug 4, 2023
@fedemkr fedemkr deleted the vault/pm-3298/update-region-selector branch August 4, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants