[PM-3382] User cannot select Email as a secondary 2FA option following SSO#2719
Merged
andrebispo5 merged 7 commits intomasterfrom Sep 6, 2023
Merged
[PM-3382] User cannot select Email as a secondary 2FA option following SSO#2719andrebispo5 merged 7 commits intomasterfrom
andrebispo5 merged 7 commits intomasterfrom
Conversation
|
No New Or Fixed Issues Found |
JaredSnider-Bitwarden
previously approved these changes
Aug 24, 2023
JaredSnider-Bitwarden
left a comment
JaredSnider-Bitwarden
left a comment
There was a problem hiding this comment.
This looks good to me, and it seems to match the work done in bitwarden/clients#5280.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix send 2FA code email on mobile client by updating it to receive and use new identity property SsoEmail2faSessionToken.
Code changes
Get new field from identity response and use it in the request for 2FA code email.
Notes for Reviewers
This should match the functionality of the clients PR here: bitwarden/clients#5280
Before you submit
dotnet format --verify-no-changes) (required)