[PM-3393] Excessive Invalid Biometric unlock attempts should automatically log out TDE users#2747
Merged
andrebispo5 merged 9 commits intomasterfrom Sep 19, 2023
Merged
Conversation
|
No New Or Fixed Issues Found |
fedemkr
reviewed
Sep 7, 2023
fedemkr
reviewed
Sep 7, 2023
fedemkr
requested changes
Sep 8, 2023
fedemkr
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
When the user has no master password or pin and exceeds the biometric login attempts, the app should logged out.
Code changes
Add action to
IsBiometricIntegrityValidAsyncto invoke when the TooManyAttempts is triggered.Add to
AppHelpersa method to check if the user doesn't have other login methods available, show a warning message and logout.Screenshots
Before you submit
dotnet format --verify-no-changes) (required)