Skip to content

[PM-3741] [PM-3750] Improvements to local storage handling#2795

Merged
mpbw2 merged 3 commits intomasterfrom
bugfix/local-data
Oct 12, 2023
Merged

[PM-3741] [PM-3750] Improvements to local storage handling#2795
mpbw2 merged 3 commits intomasterfrom
bugfix/local-data

Conversation

@mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Sep 25, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Improvements to the way we handle file attachment intents and storage restrictions

Code changes

  • FileService.cs / Constants.cs / filepaths.xml: Convert to using specific path for temporary camera images using purpose-driven path restrictions
  • MainActivity.cs: For non-camera attachments do not allow URIs pointing to our app's private storage. For camera attachments use the new temp path defined above. In both cases a resulting filename is required to continue with the attachment process as another layer of security.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@mpbw2 mpbw2 requested a review from fedemkr September 25, 2023 14:24
@mpbw2 mpbw2 requested a review from a team September 25, 2023 14:24
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 25, 2023

Logo
Checkmarx One – Scan Summary & Detailsfb6524f2-7131-41ce-accd-e91d6bddc417

No New Or Fixed Issues Found

mpbw2 and others added 2 commits September 25, 2023 10:47
@mpbw2 mpbw2 requested a review from fedemkr September 25, 2023 18:39
@mpbw2 mpbw2 merged commit bb2f1f0 into master Oct 12, 2023
@mpbw2 mpbw2 deleted the bugfix/local-data branch October 12, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants