Skip to content

[PM-4054] Rename Fido2Key to Fido2Credential#2821

Merged
fedemkr merged 2 commits intomasterfrom
vault/pm-4054/rename-fido2credential
Oct 12, 2023
Merged

[PM-4054] Rename Fido2Key to Fido2Credential#2821
fedemkr merged 2 commits intomasterfrom
vault/pm-4054/rename-fido2credential

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 12, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Rename Fido2Key to Fido2Credential on the entire codebase to comply with the WebAuthn spec.

Code changes

  • Renaming

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr requested a review from a team October 12, 2023 18:33
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details398cb0b3-4751-4d46-af96-0390684b2b0b

No New Or Fixed Issues Found

@fedemkr fedemkr merged commit f2936c9 into master Oct 12, 2023
@fedemkr fedemkr deleted the vault/pm-4054/rename-fido2credential branch October 12, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants