Skip to content

[PM-4404] Add CreationDate to Fido2Credential objects#2832

Merged
fedemkr merged 1 commit intomasterfrom
vault/pm-4404/fix-passkey-creation-time
Oct 19, 2023
Merged

[PM-4404] Add CreationDate to Fido2Credential objects#2832
fedemkr merged 1 commit intomasterfrom
vault/pm-4404/fix-passkey-creation-time

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 19, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add CreationDate to Fido2Credential objects and update the UI accordingly also fixing an issue where the date time was not being presented in local time.

Code changes

  • Fido2Credential...: Added CreationDate and updated mappings.
  • ...Page.xaml: Updated bindings to the new creation date and use DateTimeConverter with the specific format to avoid creating a new property on the VMs.
  • DateTimeConverter: Added Format property with a default value so we can customize it in specific occasions like this one.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@fedemkr fedemkr requested a review from a team October 19, 2023 20:09
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailse8e9b5e6-9bda-4ee2-ae81-d4f5f6eddc8d

No New Or Fixed Issues Found

@fedemkr fedemkr merged commit 142c314 into master Oct 19, 2023
@fedemkr fedemkr deleted the vault/pm-4404/fix-passkey-creation-time branch October 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants