Don't leak password length through mask#293
Merged
kspearrin merged 1 commit intobitwarden:masterfrom Mar 6, 2018
mpcsh:master
Merged
Don't leak password length through mask#293kspearrin merged 1 commit intobitwarden:masterfrom mpcsh:master
kspearrin merged 1 commit intobitwarden:masterfrom
mpcsh:master
Conversation
alistair23
pushed a commit
to alistair23/bytewarden-windows
that referenced
this pull request
Mar 20, 2018
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
UCan927
pushed a commit
to UCan927/BitWarden-Android
that referenced
this pull request
Jun 22, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty simple PR. I'm migrating from 1Password to Bitwarden, and I noticed that while 1Password has a constant-length password mask, Bitwarden's leaks the length of the password even when it's masked. This commit simply changes to a constant-length mask.