Skip to content

DEVOPS-1696 - Update Version Bump workflow logic#2975

Merged
vgrassia merged 1 commit intomainfrom
devops-1696_fix-version-bump-workflow
Feb 5, 2024
Merged

DEVOPS-1696 - Update Version Bump workflow logic#2975
vgrassia merged 1 commit intomainfrom
devops-1696_fix-version-bump-workflow

Conversation

@vgrassia
Copy link
Member

@vgrassia vgrassia commented Feb 1, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR updates the logic in the Version Bump workflow so that it will check for the existence of a current rc branch, if necessary, before creating the PR to bump the client version. The cut_rc job has been updated to make sure the version bump PR has been merged before cutting the rc branch.

Code changes

  • .github/workflows/version-bump.yml: See above.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@vgrassia vgrassia self-assigned this Feb 1, 2024
@vgrassia vgrassia requested a review from a team February 1, 2024 20:37
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details2bc79fcb-c979-43f9-b1c9-72d8312ae306

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 117 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 105 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 93 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 99 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 90
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 108
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 84
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 96
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 102

@vgrassia vgrassia merged commit 82b837e into main Feb 5, 2024
@vgrassia vgrassia deleted the devops-1696_fix-version-bump-workflow branch February 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants