Skip to content

[PM-6428] Implement Legacy Secure Storage#3027

Merged
fedemkr merged 7 commits intomainfrom
feature/legacy-secure-storage
Feb 26, 2024
Merged

[PM-6428] Implement Legacy Secure Storage#3027
fedemkr merged 7 commits intomainfrom
feature/legacy-secure-storage

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Feb 23, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement Legacy Secure Storage.
MAUI has changed how Secure Storage work vs Xamarin.Forms, so to avoid having to do a migration now, we are implementing the former way of Secure Storage so the update to MAUI version of the app is as seamless as possible.

Code changes

  • AndroidKeyStore: Component to get/store keys securely on Android
  • KeyChain: Component to get/store keys securely on iOS
  • SecureStorageService: Updated it to use the Xamarin Essentials (Xamarin Forms)'s components for both platforms.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

mpbw2 and others added 5 commits February 22, 2024 16:34
… storage and also fixed some pre-compiler directives so it works on Unit testing as well.
…to mimic the Microsoft.Maui.Storage.SecureStorage implementation which ensures there's always a Task (#3029)
… navigation would execute after the main navigation (#3032)
@fedemkr fedemkr marked this pull request as ready for review February 26, 2024 22:21
@fedemkr fedemkr requested a review from a team as a code owner February 26, 2024 22:21
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@fedemkr fedemkr merged commit 04e7cfe into main Feb 26, 2024
@fedemkr fedemkr deleted the feature/legacy-secure-storage branch February 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants