Skip to content

[PM-6852 ] Fix F-Droid build constant#3085

Merged
fedemkr merged 4 commits intomainfrom
fix-fdroid-trackers-removal
Mar 15, 2024
Merged

[PM-6852 ] Fix F-Droid build constant#3085
fedemkr merged 4 commits intomainfrom
fix-fdroid-trackers-removal

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Mar 15, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix CI/CD to for F-Droid build to pass the constant as it's supposed to so AppCenter and Firebase are removed from the final apk.

There seems to be an issue when building for Release configuration where the :/p CustomConstants=FDROID is not added to the DefineConstants or replaced at some point, causing the corresponding packages not to be removed from the build. So the approach was changed by not passing the parameter in the command and enabling the constant in the Directory.Build.props

Code changes

  • Directory.Build.props: Added a comment for the FDROID custom constant.
  • build.yml: Enabled FDROID custom constant on the Directory.Build.props by replacing the commented line with the uncommented version of it.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

fedemkr added 4 commits March 15, 2024 12:34
…ing this it adds the corresponding CustomConstants
…ee if that fixes passing the corresponding parameters to the build
…ash to see if that fixes passing the corresponding parameters to the build"

This reverts commit 608b23d.
@fedemkr fedemkr requested a review from a team March 15, 2024 18:51
@fedemkr fedemkr requested a review from a team as a code owner March 15, 2024 18:51
@fedemkr fedemkr merged commit f343a2c into main Mar 15, 2024
@fedemkr fedemkr deleted the fix-fdroid-trackers-removal branch March 15, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants