Handle exception when adding attachment that does not exist on file system.#449
Merged
kspearrin merged 1 commit intobitwarden:masterfrom Jan 22, 2019
devsecdan:master
Merged
Handle exception when adding attachment that does not exist on file system.#449kspearrin merged 1 commit intobitwarden:masterfrom devsecdan:master
kspearrin merged 1 commit intobitwarden:masterfrom
devsecdan:master
Conversation
Member
|
Thanks |
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitwarden crashes when trying to add a file that does not exist on the filesystem as an attachment.
The Android 'Documents' app seems to keep a cache of downloaded files despite those files having been deleted off of the file system. This causes Bitwarden to crash when the user selects them.
I figure that presenting some error to the user when this happens makes sense, but beyond the generic "An error has occurred" message, I couldn't find a suitable resource.