PM-16630 Add action card to start add login coachmarks#4596
Closed
dseverns-livefront wants to merge 2 commits intomainfrom
Closed
PM-16630 Add action card to start add login coachmarks#4596dseverns-livefront wants to merge 2 commits intomainfrom
dseverns-livefront wants to merge 2 commits intomainfrom
Conversation
dseverns-livefront
requested review from
a team,
ahaisting-livefront,
brian-livefront,
david-livefront and
phil-livefront
as code owners
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4596 +/- ##
==========================================
+ Coverage 88.35% 88.38% +0.02%
==========================================
Files 603 603
Lines 40746 40815 +69
Branches 5738 5746 +8
==========================================
+ Hits 36003 36074 +71
Misses 2742 2742
+ Partials 2001 1999 -2 ☔ View full report in Codecov by Sentry. |
dseverns-livefront
force-pushed
the
PM-16630-new-login-coachmark-card
branch
from
a326c0e to
49bf973
Compare
Collaborator
Author
pm16630.mp4 |
| actionText = stringResource(R.string.get_started), | ||
| onActionClick = loginItemTypeHandlers.onStartLoginCoachMarkTour, | ||
| onDismissClick = loginItemTypeHandlers.onDismissLearnAboutLoginsCard, | ||
| modifier = Modifier.standardHorizontalMargin(), |
Collaborator
There was a problem hiding this comment.
Wanna add the fillMaxWidth modifier too
| firstTimeActionManager | ||
| .hasSeenAddLoginCoachMarkFlow | ||
| .combine( | ||
| featureFlagManager.getFeatureFlagFlow(key = FlagKey.OnboardingFlow), |
Collaborator
There was a problem hiding this comment.
Could this feature flag logic be done in the firstTimeActionManager?
| * The value for the hasSeenAddLoginCoachMark has changed. | ||
| */ | ||
| data class HasSeenAddLoginCoachMarkValueChangeReceive( | ||
| val newValue: Boolean, |
Collaborator
There was a problem hiding this comment.
Instead of newValue could we be hasSeenCoachMark or something along those lines
dseverns-livefront
force-pushed
the
PM-16630-new-login-coachmark-card
branch
from
0241281 to
bd56862
Compare
dseverns-livefront
force-pushed
the
PM-16630-new-login-coachmark-card
branch
from
bd56862 to
45062df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16630
📔 Objective
📸 Screenshots
pm16630.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes