PM-16621 add explore generator card to be able to trigger coach marks#4607
PM-16621 add explore generator card to be able to trigger coach marks#4607dseverns-livefront wants to merge 3 commits intomainfrom
Conversation
dseverns-livefront
requested review from
a team,
ahaisting-livefront,
brian-livefront,
david-livefront and
phil-livefront
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.01%
==========================================
Files 604 604
Lines 40832 40894 +62
Branches 5727 5735 +8
==========================================
+ Hits 36090 36152 +62
Misses 2751 2751
Partials 1991 1991 ☔ View full report in Codecov by Sentry. |
dseverns-livefront
force-pushed
the
PM-16621-explore-generator-card
branch
from
0a1b249 to
e2f5f94
Compare
| ) | ||
| } | ||
|
|
||
| override fun getHasSeenGeneratorCoachMark(): Boolean? = |
There was a problem hiding this comment.
This could be a val
| .getHasSeenGeneratorCoachMarkFlow() | ||
| .map { it ?: false } | ||
| .combine( | ||
| featureFlagManager.getFeatureFlagFlow(FlagKey.OnboardingFlow), |
| /** | ||
| * Gets the Boolean value of if the Generator CoachMark tour has been interacted with. | ||
| */ | ||
| fun getHasSeenGeneratorCoachMark(): Boolean? |
There was a problem hiding this comment.
🎨 Since we are using this logic on other screens, should we make an enum for the screen and have one function in the disk source that accepts the enum type instead of making funs for each individual screen?
There was a problem hiding this comment.
might save some time for other screens if they get added but also I can see both sides so its just an idea vs a change request kinda thing. Go birds
3 participants
🎟️ Tracking
PM-16621
📔 Objective
📸 Screenshots
pm16621.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes