[PM-19108] Add privileged app management screen #4862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4862 +/- ##
==========================================
- Coverage 89.49% 83.05% -6.44%
==========================================
Files 499 628 +129
Lines 42507 48904 +6397
Branches 5985 6758 +773
==========================================
+ Hits 38040 40619 +2579
- Misses 2399 6011 +3612
- Partials 2068 2274 +206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/settings-mgmt
branch
from
e26c43a to
15ae542
Compare
| } | ||
|
|
||
| item { | ||
| Spacer(modifier = Modifier.height(88.dp)) |
Collaborator
There was a problem hiding this comment.
We usually reserve the 88.dp for screens that have a FAB and 16.dp for the rest of them
| } | ||
|
|
||
| @Composable | ||
| private fun LazyItemScope.PrivilegedAppHeaderItem( |
Collaborator
There was a problem hiding this comment.
A LazyItemScope should not be composable?
| if (canDelete) { | ||
| BitwardenStandardIconButton( | ||
| vectorIconRes = R.drawable.ic_send_pending_delete, | ||
| contentDescription = "", |
Collaborator
There was a problem hiding this comment.
This should have a contentDescription
| cardStyle: CardStyle, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Row( |
Collaborator
There was a problem hiding this comment.
We should already have standard components for this sort of thing already
|
|
||
| @Preview | ||
| @Composable | ||
| private fun PrivilegedAppsListScreenPreview() { |
Collaborator
There was a problem hiding this comment.
Can we call this function PrivilegedAppsListScreen_preview
| Spacer(modifier = Modifier.height(8.dp)) | ||
| } | ||
| itemsIndexed( | ||
| key = { _, item -> "communityTrust_${item.packageName}_${item.signature}" }, |
| cardStyle = state.communityTrustedApps | ||
| .toListItemCardStyle(index = index), | ||
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) |
Collaborator
There was a problem hiding this comment.
Can we use the standardHorizontalMargin() function here
| modifier = Modifier | ||
| .padding(horizontal = 16.dp) | ||
| .fillMaxWidth() | ||
| .animateItem(), |
| data class Fido2TrustState( | ||
| val googleTrustedApps: ImmutableList<PrivilegedAppListItem>, | ||
| val communityTrustedApps: ImmutableList<PrivilegedAppListItem>, | ||
| val userTrustedApps: ImmutableList<PrivilegedAppListItem>, |
Collaborator
There was a problem hiding this comment.
I love that we can put ImmutableLists directly into parcelable classes now 👨🍳
| } | ||
|
|
||
| override suspend fun getCommunityTrustedPrivilegedAppsOrNull(): PrivilegedAppAllowListJson? { | ||
| return withContext(ioScope.coroutineContext) { |
Collaborator
There was a problem hiding this comment.
Do we need this specifically for the json .decodeFromStringOrNull part?
Introduces the ability to trust privileged applications for FIDO2 operations. If a calling application is acting as a privileged application but is not yet trusted, the user will be given the option to trust the app and continue the operation, or to cancel the operation without trusting the application. If the application is trusted, subsequent requests from the application will be treated as a trusted application without user interaction.
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/trust-dialog
branch
from
465c5ce to
9beb3ec
Compare
Allow users to manage trusted privileged applications and view privileged applications that are trusted by external sources.
…ps list - Added a new vector graphic file `ic_delete.xml` for the delete icon. - Updated the delete button icon in the `PrivilegedAppsListScreen` from `ic_send_pending_delete` to `ic_delete`.
- Removed unused string resources: `trusted_by_google_x`, `trusted_by_you_x`, and `trusted_by_the_community_c`.
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/settings-mgmt
branch
from
208e972 to
3c1ef13
Compare
1 task
1 task
SaintPatrck
force-pushed
the
innovation-sprint/privileged-apps/trust-dialog
branch
4 times, most recently
from
51c8a2e to
1f201b0
Compare
Base automatically changed from
innovation-sprint/privileged-apps/trust-dialog
to
main
June 6, 2025 18:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-19108
📔 Objective
Allow users to manage trusted privileged applications and view
privileged applications that are trusted by external sources.
📸 Screenshots
Screen_recording_20250313_161906.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes