Update multi-tonal illustrations and icons to support dynamic colors #4897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for dynamic colors in the application. - A new setting `isDynamicColorsEnabled` is added to `SettingsDiskSource` and `SettingsRepository` to persist and retrieve the dynamic colors preference. - A new flow `isDynamicColorsEnabledFlow` is added to track the changes of `isDynamicColorsEnabled`. - A new switch "Dynamic colors" is added in the Appearance Screen. - The `MainState` is updated with the `isDynamicColorsEnabled` attribute. - `BitwardenTheme` is updated to set the dynamic color. - The `AppearanceViewModel` is updated to set the `isDynamicColorsEnabled`.
- Changed the toggle button switch color to `onPrimary` in the `dynamicColorScheme`.
This commit introduces a warning dialog that is displayed when the user attempts to enable dynamic colors in the appearance settings.
- Changed the toggle button switch `backgroundOff` color to `onSurfaceVariant`. - Changed the toggle button switch color to `onPrimary`.
david-livefront
requested review from
a team,
ahaisting-livefront,
brian-livefront,
dseverns-livefront and
phil-livefront
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## innovation-sprint/dynamic-colors/base #4897 +/- ##
=========================================================================
- Coverage 89.36% 83.93% -5.43%
=========================================================================
Files 496 615 +119
Lines 42254 48054 +5800
Branches 5990 6685 +695
=========================================================================
+ Hits 37759 40336 +2577
- Misses 2421 5459 +3038
- Partials 2074 2259 +185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
david-livefront
force-pushed
the
multi-tonal-imagery
branch
from
2fe98f0 to
5551a19
Compare
SaintPatrck
force-pushed
the
multi-tonal-imagery
branch
from
5551a19 to
9a4a22f
Compare
SaintPatrck
force-pushed
the
multi-tonal-imagery
branch
from
9a4a22f to
5c4aa5c
Compare
phil-livefront
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
Add support for dynamic colors in multi-tonal vector illustrations and icons.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes