Add logs for testing validatePrivilegedApp functionality #5315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5315 +/- ##
==========================================
- Coverage 82.80% 82.73% -0.08%
==========================================
Files 678 695 +17
Lines 50900 51302 +402
Branches 6921 6923 +2
==========================================
+ Hits 42149 42444 +295
- Misses 6437 6544 +107
Partials 2314 2314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
force-pushed
the
passkeys-validate-privilege-app-temp-logs
branch
from
ff79c06 to
98117ff
Compare
SaintPatrck
reviewed
Jun 5, 2025
| Timber.e("Success") | ||
| ValidateOriginResult.Success(null) | ||
| } else { | ||
| Timber.e("Calling application is not linked per v1/assetlinks:check API") |
Collaborator
Author
|
Closing as we now have direction on a permanent solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
Add logs for testing
validatePrivilegedAppfunctionality.This PR is not intended to merge and is here for reference.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes